Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure in IngestServiceTests > testValidateNotInUse #79145

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Fix failure in IngestServiceTests > testValidateNotInUse #79145

merged 1 commit into from
Oct 14, 2021

Conversation

danhermann
Copy link
Contributor

Fixes the case where both defaultIndicesCount and finalIndicesCount were randomly assigned 0.

@danhermann danhermann added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.16.0 labels Oct 14, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Oct 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

martijnvg
martijnvg approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhermann
Copy link
Contributor Author

Thank you, @martijnvg!

@danhermann
Copy link
Contributor Author

Merging over unrelated flaky test failure.

@danhermann danhermann merged commit 49dda6c into elastic:master Oct 14, 2021
@danhermann danhermann deleted the fix_pipeline_delete_test2 branch October 14, 2021 13:14
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Oct 18, 2021
@danhermann
Fix failure in IngestServiceTests > testValidateNotInUse (elastic#79145)
02904bf
@danhermann danhermann mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees
No one assigned
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danhermann @elasticmachine @martijnvg @jakelandis